Skip to content

feat(Output): add console #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(Output): add console #333

wants to merge 18 commits into from

Conversation

Dsaquel
Copy link
Contributor

@Dsaquel Dsaquel commented Apr 12, 2025

inspiration from #201 (thanks)

This solution does not require a network connection, it is opt-in and way much lighter than loading the whole chobitsu devtool.

Copy link

vercel bot commented Apr 12, 2025

@Dsaquel is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Apr 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vue/repl@333

commit: b554976

@Dsaquel Dsaquel changed the title Feat/console feat(Sandbox): add console Apr 12, 2025
@Dsaquel Dsaquel marked this pull request as ready for review April 12, 2025 14:27
@edison1105 edison1105 requested a review from wangcch April 13, 2025 12:43
@wangcch
Copy link
Collaborator

wangcch commented Apr 14, 2025

Cool ~

To make the sandbox lighter while preserving iframe-container, can we integrate the console into the Output? Or should we build a plugin instead?

more: svelte playground (console)
play repo

@Dsaquel
Copy link
Contributor Author

Dsaquel commented Apr 14, 2025

To make the sandbox lighter while preserving iframe-container, can we integrate the console into the Output ?

Sure i can definitely do this

Or should we build a plugin instead?

Anyway im ok with any solution we integrate a console 👍, maybe we can ask others people their opinions.

@Dsaquel Dsaquel changed the title feat(Sandbox): add console feat(Output): add console Apr 14, 2025
@Dsaquel Dsaquel requested a review from wangcch April 16, 2025 20:42
Copy link
Contributor Author

@Dsaquel Dsaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of changes caused by pnpm format

@wangcch
Copy link
Collaborator

wangcch commented Apr 17, 2025

🤔 Maybe can use emit(log) + slot(console) + store.callback to implement the console plugin. Like the editor, the main package also does not depend on luna-console.

@Dsaquel
Copy link
Contributor Author

Dsaquel commented Apr 17, 2025

🤔 Maybe can use emit(log) + slot(console) + store.callback to implement the console plugin. Like the editor, the main package also does not depend on luna-console.

I think this is good, thansk for advice i'll try it.

@Dsaquel Dsaquel requested a review from wangcch April 17, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants